From: Jonas Dreßler <verdre@v0yd.nl>
Date: Thu, 21 Nov 2019 09:04:12 +0000 (+0700)
Subject: status/network: Compare icon name to NULL instead of empty string
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~781^2^2~213
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=aac01f1c9e1d31cbbcd707aa003f9470b2130eb1;p=gnome-shell.git

status/network: Compare icon name to NULL instead of empty string

Since the last commit we set the gicon property of StIcon to NULL if an
empty string was given when setting the icon name, this means
`st_icon_get_icon_name()` will return NULL instead of an empty string.

When `getIndicatorIcon()` returns an empty string, the icon_name
property will now be set to NULL, so compare it to NULL here.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/888
---

diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index 2f9cd0e2b..a8d2d0893 100644
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -2069,6 +2069,6 @@ class Indicator extends PanelMenu.SystemIndicator {
         }
 
         this._vpnIndicator.icon_name = this._vpnSection.getIndicatorIcon();
-        this._vpnIndicator.visible = this._vpnIndicator.icon_name != '';
+        this._vpnIndicator.visible = this._vpnIndicator.icon_name !== null;
     }
 });